rpc: stabilize chainhead backend #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Oct 1, 2024
niklasad1
changed the title
niklasad1
changed the title
jsdw
reviewed
Oct 2, 2024
subxt/src/backend/chain_head/mod.rs
Outdated
Comment on lines
114
to
115
| /// On native this is spawned on the tokio runtime. | ||
| /// On web this is spawned on the wasm_bindgen. |
There was a problem hiding this comment.
Suggested change
| /// On native this is spawned on the tokio runtime. | |
| /// On web this is spawned on the wasm_bindgen. | |
| /// On native this task is spawned on the tokio runtime. | |
| /// On web this task is spawned via wasm_bindgen. |
jsdw
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Nice!
From our chat in the rust call I think we agree that it's worth adding eg a "runtime" feature flag which on native enables the relevant tokio thing and on web enables the web thing, but we could leave this for a separate PR and I don't think it's super urgent!
I guess raising an issue to look at the subscriptions halting is the other thing to do, but again not related to this PR :)
niklasad1
commented
Oct 3, 2024
lexnv
approved these changes
Oct 3, 2024
niklasad1
commented
Oct 3, 2024
niklasad1
commented
Oct 3, 2024
niklasad1
commented
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1753